On 10.05.11 04:55:10, Martin Schwidefsky wrote: > On Tue, 3 May 2011 10:55:40 +0200 > Robert Richter <robert.richter@xxxxxxx> wrote: > > > On 02.05.11 09:48:05, Nicolas Kaiser wrote: > > > Checking 'oprofile_min_interval < 0' and > > > 'oprofile_max_interval < 0' doesn't work because > > > 'oprofile_min_interval' and 'oprofile_max_interval' are unsigned. > > > > max/min_interval are through all the code always unsigned. I don't > > know how min/max_sampl_rate in struct hws_qsi_info_block is spec'ed, > > but there it is unsigned too. > > > > So the best would be to return qsi.min/max_sampl_rate in > > hwsampler_query_min/max_interval() directly with no error codes as > > unsigned longs and to change the code in oprofile_hwsampler_init() to > > check for null. Both functions hwsampler_query_min/max_interval() > > could be moved to hwsampler.h as static inline functions. This makes > > the code also easier. > > > > This patch does not handle the null value case and the data truncation > > by casting from unsigned to singed is not fixed. > > Ok, the improved patch now looks like this: > -- > Subject: [PATCH] s390: oprofile: fix min/max interval query checks > > From: Martin Schwidefsky <schwidefsky@xxxxxxxxxx> > > oprofile_min_interval and oprofile_max_interval are unsigned, checking > for negative values doesn't work. Change hwsampler_query_min_interval > and hwsampler_query_max_interval to return an unsigned long and > check for a zero value instead. > > Reported-by: Nicolas Kaiser <nikai@xxxxxxxxx> > Signed-off-by: Martin Schwidefsky <schwidefsky@xxxxxxxxxx> Looks good. Acked-by: Robert Richter <robert.richter@xxxxxxx> Martin, can you queue this up? Thanks, -Robert -- Advanced Micro Devices, Inc. Operating System Research Center -- To unsubscribe from this list: send the line "unsubscribe linux-s390" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
