> > @@ -1016,21 +1016,21 @@ int __ref smp_rescan_cpus(void)
> >
> > Â Â Â Âget_online_cpus();
> > Â Â Â Âmutex_lock(&smp_cpu_state_mutex);
> > - Â Â Â newcpus = cpu_present_map;
> > + Â Â Â cpumask_copy(&newcpus, cpu_present_mask);
> > Â Â Â Ârc = __smp_rescan_cpus();
> > Â Â Â Âif (rc)
> > Â Â Â Â Â Â Â Âgoto out;
> > - Â Â Â cpus_andnot(newcpus, cpu_present_map, newcpus);
> > - Â Â Â for_each_cpu_mask(cpu, newcpus) {
> > + Â Â Â cpumask_andnot(&newcpus, cpu_present_mask, &newcpus);
> > + Â Â Â for_each_cpu(cpu,&newcpus) {
> please, could you add a space between cpu and ,&newcpus?
Thank you for finding.
>From 46812a238d85243a18dcec0749ba42d5f1a0e1ab Mon Sep 17 00:00:00 2001
From: KOSAKI Motohiro <kosaki.motohiro@xxxxxxxxxxxxxx>
Date: Fri, 29 Apr 2011 00:44:43 +0900
Subject: [PATCH] s390: coding style fix
Signed-off-by: KOSAKI Motohiro <kosaki.motohiro@xxxxxxxxxxxxxx>
---
arch/s390/kernel/smp.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/arch/s390/kernel/smp.c b/arch/s390/kernel/smp.c
index 4cc09b8..a80798b 100644
--- a/arch/s390/kernel/smp.c
+++ b/arch/s390/kernel/smp.c
@@ -1021,7 +1021,7 @@ int __ref smp_rescan_cpus(void)
if (rc)
goto out;
cpumask_andnot(&newcpus, cpu_present_mask, &newcpus);
- for_each_cpu(cpu,&newcpus) {
+ for_each_cpu(cpu, &newcpus) {
rc = smp_add_present_cpu(cpu);
if (rc)
set_cpu_present(cpu, false);
--
1.7.3.1
--
To unsubscribe from this list: send the line "unsubscribe linux-s390" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
