On Fri, Mar 11, 2011 at 11:04:42AM -0500, chenliu@xxxxxxxxxxxxxxxxxx wrote: > Thanks Heiko. I've followed your advice to give a new patch here. > --------------------------------- > > This patch fixed bugzilla #12965: > https://bugzilla.kernel.org/show_bug.cgi?id=12965 > > The original code contains some inproper use of sprintf > function where a buffer is used both as input string > as well as output string. It should remember the written > bytes in the previous and use that as the offset for > later writing. Also replace sprintf with snprintf. > > Signed-off-by: Chen Liu <chenliunju@xxxxxxxxx> Hi Chen, I still want a patch where the From: and Signed-off-by: lines are identical. Otherwise I won't take the patch. Also you didn't answer my other question: did you actually test that after your change the code still works? If not, then I would have to do that. The patch looks ok so far (besides two lines that could be removed). Thanks, Heiko -- To unsubscribe from this list: send the line "unsubscribe linux-s390" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
