Hello Oleg, On Thu, 2010-11-25 at 14:26 +0100, Oleg Nesterov wrote: > On 11/19, Michael Holzheu wrote: > > > > From: Michael Holzheu <holzheu@xxxxxxxxxxxxxxxxxx> > > > > With this patch the (full) cumulative CPU time is added to "struct taskstats". > > The CPU time is only returned for the thread group leader. > > > > ... > > > > + if (tsk->tgid == tsk->pid > > thread_group_leader() ? Yes, that's better. > > && lock_task_sighand(tsk, &flags)) { > > Do you really need ->siglock? Starting from 2.6.35 it is always > safe to access ->signal. Hmmm, if you say that... I just did it like it is done in e.g. fs/proc/base.c (proc_pid_limits). Can we remove the locking there, too? Michael -- To unsubscribe from this list: send the line "unsubscribe linux-s390" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html