On 11/16, Michael Holzheu wrote: > > On Sat, 2010-11-13 at 19:38 +0100, Oleg Nesterov wrote: > > I already asked you to split these changes, perhaps you can do this? > > Say, bacct_add_tsk() looks overcomplicated, the change in copy_process() > > shouldn't introduce the new CLONE_THREAD check, not sure I understand > > why release_task() was chosen for reparenting, other nits... > > I want to establish the new hierarchy when a new process is forked and > not for new threads, therefore the check for CLONE_THREAD in > copy_process(). Yes, but copy_process() already checks CLONE_THREAD many times. No need to introduce the new check. > I do the reparenting with reparent_acct() when a process > dies, therefore the check for "group_dead" in exit_signal(). And it is not clear to me why release_task() is better than exit_notify(). That said, perhaps I'll understand this reading the next version. That is why I asked to split. Oleg. -- To unsubscribe from this list: send the line "unsubscribe linux-s390" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
