On Mon, 8 Mar 2010 12:57:51 +0000 d binderman <dcb314@xxxxxxxxxxx> wrote: > Hello there Martin, > > > I don't agree with cppcheck: > > > > token = strsep(&str, ","); > > if (!token || strlen(token)>= ZFCP_BUS_ID_SIZE) > > goto err_out; > > strncpy(busid, token, ZFCP_BUS_ID_SIZE); > > > > strlen(token) < ZFCP_BUS_ID_SIZE which means that the strncpy will > > copy the terminating zero byte. The code is correct. > > Thanks for pointing this out. Would plain > > strcpy(busid, token); > > be simpler than the strncpy ? Yes, that would be simpler. Dunno if it is worth the effort. -- blue skies, Martin. "Reality continues to ruin my life." - Calvin. -- To unsubscribe from this list: send the line "unsubscribe linux-s390" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
