Hello there Martin, > I don't agree with cppcheck: > > token = strsep(&str, ","); > if (!token || strlen(token)>= ZFCP_BUS_ID_SIZE) > goto err_out; > strncpy(busid, token, ZFCP_BUS_ID_SIZE); > > strlen(token) < ZFCP_BUS_ID_SIZE which means that the strncpy will > copy the terminating zero byte. The code is correct. Thanks for pointing this out. Would plain strcpy(busid, token); be simpler than the strncpy ? Regards David Binderman _________________________________________________________________ We want to hear all your funny, exciting and crazy Hotmail stories. Tell us now http://clk.atdmt.com/UKM/go/195013117/direct/01/-- To unsubscribe from this list: send the line "unsubscribe linux-s390" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
