Hi Liao, kernel test robot noticed the following build errors: [auto build test ERROR on abelloni/rtc-next] [also build test ERROR on tegra/for-next linus/master v6.11-rc4 next-20240823] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Liao-Yuanhong/rtc-rtc-at91rm9200-Use-devm_clk_get_enabled-helpers/20240822-150754 base: https://git.kernel.org/pub/scm/linux/kernel/git/abelloni/linux.git rtc-next patch link: https://lore.kernel.org/r/20240821092846.20138-2-liaoyuanhong%40vivo.com patch subject: [PATCH 1/7] rtc:rtc-at91rm9200:Use devm_clk_get_enabled() helpers config: sparc64-randconfig-r064-20240823 (https://download.01.org/0day-ci/archive/20240823/202408231657.ZitX62vV-lkp@xxxxxxxxx/config) compiler: sparc64-linux-gcc (GCC) 14.1.0 reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240823/202408231657.ZitX62vV-lkp@xxxxxxxxx/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot <lkp@xxxxxxxxx> | Closes: https://lore.kernel.org/oe-kbuild-all/202408231657.ZitX62vV-lkp@xxxxxxxxx/ All errors (new ones prefixed by >>): drivers/rtc/rtc-at91rm9200.c: In function 'at91_rtc_probe': drivers/rtc/rtc-at91rm9200.c:473:13: warning: unused variable 'ret' [-Wunused-variable] 473 | int ret = 0; | ^~~ drivers/rtc/rtc-at91rm9200.c: At top level: drivers/rtc/rtc-at91rm9200.c:89:24: error: expected declaration specifiers or '...' before '(' token 89 | writel_relaxed((val), at91_rtc_regs + field) | ^ drivers/rtc/rtc-at91rm9200.c:506:9: note: in expansion of macro 'at91_rtc_write' 506 | at91_rtc_write(AT91_RTC_CR, 0); | ^~~~~~~~~~~~~~ drivers/rtc/rtc-at91rm9200.c:89:31: error: expected declaration specifiers or '...' before 'at91_rtc_regs' 89 | writel_relaxed((val), at91_rtc_regs + field) | ^~~~~~~~~~~~~ drivers/rtc/rtc-at91rm9200.c:506:9: note: in expansion of macro 'at91_rtc_write' 506 | at91_rtc_write(AT91_RTC_CR, 0); | ^~~~~~~~~~~~~~ drivers/rtc/rtc-at91rm9200.c:89:24: error: expected declaration specifiers or '...' before '(' token 89 | writel_relaxed((val), at91_rtc_regs + field) | ^ drivers/rtc/rtc-at91rm9200.c:507:9: note: in expansion of macro 'at91_rtc_write' 507 | at91_rtc_write(AT91_RTC_MR, at91_rtc_read(AT91_RTC_MR) & ~AT91_RTC_HRMOD); | ^~~~~~~~~~~~~~ drivers/rtc/rtc-at91rm9200.c:89:31: error: expected declaration specifiers or '...' before 'at91_rtc_regs' 89 | writel_relaxed((val), at91_rtc_regs + field) | ^~~~~~~~~~~~~ drivers/rtc/rtc-at91rm9200.c:507:9: note: in expansion of macro 'at91_rtc_write' 507 | at91_rtc_write(AT91_RTC_MR, at91_rtc_read(AT91_RTC_MR) & ~AT91_RTC_HRMOD); | ^~~~~~~~~~~~~~ In file included from include/linux/bits.h:6, from include/linux/bitops.h:6, from include/linux/kernel.h:23, from include/linux/clk.h:13, from drivers/rtc/rtc-at91rm9200.c:18: include/vdso/bits.h:7:33: error: expected declaration specifiers or '...' before '(' token 7 | #define BIT(nr) (UL(1) << (nr)) | ^ drivers/rtc/rtc-at91rm9200.c:66:41: note: in expansion of macro 'BIT' 66 | #define AT91_RTC_ACKUPD BIT(0) /* Acknowledge for Update */ | ^~~ drivers/rtc/rtc-at91rm9200.c:510:28: note: in expansion of macro 'AT91_RTC_ACKUPD' 510 | at91_rtc_write_idr(AT91_RTC_ACKUPD | AT91_RTC_ALARM | | ^~~~~~~~~~~~~~~ drivers/rtc/rtc-at91rm9200.c:514:9: warning: data definition has no type or storage class 514 | ret = devm_request_irq(&pdev->dev, irq, at91_rtc_interrupt, | ^~~ drivers/rtc/rtc-at91rm9200.c:514:9: error: type defaults to 'int' in declaration of 'ret' [-Wimplicit-int] drivers/rtc/rtc-at91rm9200.c:514:33: error: 'pdev' undeclared here (not in a function); did you mean 'cdev'? 514 | ret = devm_request_irq(&pdev->dev, irq, at91_rtc_interrupt, | ^~~~ | cdev In file included from include/linux/bcd.h:5, from drivers/rtc/rtc-at91rm9200.c:16: >> include/linux/compiler.h:55:23: error: expected identifier or '(' before 'if' 55 | #define if(cond, ...) if ( __trace_if_var( !!(cond , ## __VA_ARGS__) ) ) | ^~ drivers/rtc/rtc-at91rm9200.c:517:9: note: in expansion of macro 'if' 517 | if (ret) { | ^~ >> include/linux/compiler.h:71:2: error: expected identifier or '(' before ')' token 71 | }) | ^ include/linux/compiler.h:57:69: note: in expansion of macro '__trace_if_value' 57 | #define __trace_if_var(cond) (__builtin_constant_p(cond) ? (cond) : __trace_if_value(cond)) | ^~~~~~~~~~~~~~~~ include/linux/compiler.h:55:28: note: in expansion of macro '__trace_if_var' 55 | #define if(cond, ...) if ( __trace_if_var( !!(cond , ## __VA_ARGS__) ) ) | ^~~~~~~~~~~~~~ drivers/rtc/rtc-at91rm9200.c:517:9: note: in expansion of macro 'if' 517 | if (ret) { | ^~ >> include/linux/compiler.h:55:23: error: expected identifier or '(' before 'if' 55 | #define if(cond, ...) if ( __trace_if_var( !!(cond , ## __VA_ARGS__) ) ) | ^~ drivers/rtc/rtc-at91rm9200.c:525:9: note: in expansion of macro 'if' 525 | if (!device_can_wakeup(&pdev->dev)) | ^~ >> include/linux/compiler.h:71:2: error: expected identifier or '(' before ')' token 71 | }) | ^ include/linux/compiler.h:57:69: note: in expansion of macro '__trace_if_value' 57 | #define __trace_if_var(cond) (__builtin_constant_p(cond) ? (cond) : __trace_if_value(cond)) | ^~~~~~~~~~~~~~~~ include/linux/compiler.h:55:28: note: in expansion of macro '__trace_if_var' 55 | #define if(cond, ...) if ( __trace_if_var( !!(cond , ## __VA_ARGS__) ) ) | ^~~~~~~~~~~~~~ drivers/rtc/rtc-at91rm9200.c:525:9: note: in expansion of macro 'if' 525 | if (!device_can_wakeup(&pdev->dev)) | ^~ >> include/linux/compiler.h:55:23: error: expected identifier or '(' before 'if' 55 | #define if(cond, ...) if ( __trace_if_var( !!(cond , ## __VA_ARGS__) ) ) | ^~ drivers/rtc/rtc-at91rm9200.c:528:9: note: in expansion of macro 'if' 528 | if (at91_rtc_config->has_correction) | ^~ >> include/linux/compiler.h:71:2: error: expected identifier or '(' before ')' token 71 | }) | ^ include/linux/compiler.h:57:69: note: in expansion of macro '__trace_if_value' 57 | #define __trace_if_var(cond) (__builtin_constant_p(cond) ? (cond) : __trace_if_value(cond)) | ^~~~~~~~~~~~~~~~ include/linux/compiler.h:55:28: note: in expansion of macro '__trace_if_var' 55 | #define if(cond, ...) if ( __trace_if_var( !!(cond , ## __VA_ARGS__) ) ) | ^~~~~~~~~~~~~~ drivers/rtc/rtc-at91rm9200.c:528:9: note: in expansion of macro 'if' 528 | if (at91_rtc_config->has_correction) | ^~ drivers/rtc/rtc-at91rm9200.c:530:9: error: expected identifier or '(' before 'else' 530 | else | ^~~~ drivers/rtc/rtc-at91rm9200.c:533:12: error: expected '=', ',', ';', 'asm' or '__attribute__' before '->' token 533 | rtc->range_min = RTC_TIMESTAMP_BEGIN_1900; | ^~ drivers/rtc/rtc-at91rm9200.c:534:12: error: expected '=', ',', ';', 'asm' or '__attribute__' before '->' token 534 | rtc->range_max = RTC_TIMESTAMP_END_2099; | ^~ drivers/rtc/rtc-at91rm9200.c:535:9: warning: data definition has no type or storage class 535 | ret = devm_rtc_register_device(rtc); | ^~~ drivers/rtc/rtc-at91rm9200.c:535:9: error: type defaults to 'int' in declaration of 'ret' [-Wimplicit-int] drivers/rtc/rtc-at91rm9200.c:535:9: error: redefinition of 'ret' drivers/rtc/rtc-at91rm9200.c:514:9: note: previous definition of 'ret' with type 'int' 514 | ret = devm_request_irq(&pdev->dev, irq, at91_rtc_interrupt, | ^~~ In file included from drivers/rtc/rtc-at91rm9200.c:27: drivers/rtc/rtc-at91rm9200.c:535:40: error: 'rtc' undeclared here (not in a function) 535 | ret = devm_rtc_register_device(rtc); | ^~~ include/linux/rtc.h:246:49: note: in definition of macro 'devm_rtc_register_device' 246 | __devm_rtc_register_device(THIS_MODULE, device) | ^~~~~~ >> include/linux/compiler.h:55:23: error: expected identifier or '(' before 'if' 55 | #define if(cond, ...) if ( __trace_if_var( !!(cond , ## __VA_ARGS__) ) ) | ^~ drivers/rtc/rtc-at91rm9200.c:536:9: note: in expansion of macro 'if' 536 | if (ret) | ^~ >> include/linux/compiler.h:71:2: error: expected identifier or '(' before ')' token 71 | }) | ^ include/linux/compiler.h:57:69: note: in expansion of macro '__trace_if_value' 57 | #define __trace_if_var(cond) (__builtin_constant_p(cond) ? (cond) : __trace_if_value(cond)) | ^~~~~~~~~~~~~~~~ include/linux/compiler.h:55:28: note: in expansion of macro '__trace_if_var' 55 | #define if(cond, ...) if ( __trace_if_var( !!(cond , ## __VA_ARGS__) ) ) | ^~~~~~~~~~~~~~ drivers/rtc/rtc-at91rm9200.c:536:9: note: in expansion of macro 'if' 536 | if (ret) | ^~ include/vdso/bits.h:7:33: error: expected declaration specifiers or '...' before '(' token 7 | #define BIT(nr) (UL(1) << (nr)) | ^ drivers/rtc/rtc-at91rm9200.c:68:41: note: in expansion of macro 'BIT' 68 | #define AT91_RTC_SECEV BIT(2) /* Second Event */ | ^~~ drivers/rtc/rtc-at91rm9200.c:542:28: note: in expansion of macro 'AT91_RTC_SECEV' 542 | at91_rtc_write_ier(AT91_RTC_SECEV); | ^~~~~~~~~~~~~~ In file included from include/linux/device.h:15, from include/linux/platform_device.h:13, from drivers/rtc/rtc-at91rm9200.c:26: include/linux/dev_printk.h:108:10: error: expected identifier or '(' before '{' token 108 | ({ \ | ^ include/linux/dev_printk.h:160:9: note: in expansion of macro 'dev_printk_index_wrap' 160 | dev_printk_index_wrap(_dev_info, KERN_INFO, dev, dev_fmt(fmt), ##__VA_ARGS__) | ^~~~~~~~~~~~~~~~~~~~~ drivers/rtc/rtc-at91rm9200.c:544:9: note: in expansion of macro 'dev_info' 544 | dev_info(&pdev->dev, "AT91 Real Time Clock driver.\n"); | ^~~~~~~~ drivers/rtc/rtc-at91rm9200.c:545:9: error: expected identifier or '(' before 'return' 545 | return 0; | ^~~~~~ drivers/rtc/rtc-at91rm9200.c:546:1: error: expected identifier or '(' before '}' token 546 | } | ^ drivers/rtc/rtc-at91rm9200.c: In function 'at91_rtc_probe': drivers/rtc/rtc-at91rm9200.c:504:9: warning: control reaches end of non-void function [-Wreturn-type] 504 | } | ^ drivers/rtc/rtc-at91rm9200.c: At top level: drivers/rtc/rtc-at91rm9200.c:456:35: warning: 'sama5d4_rtc_ops' defined but not used [-Wunused-const-variable=] 456 | static const struct rtc_class_ops sama5d4_rtc_ops = { | ^~~~~~~~~~~~~~~ drivers/rtc/rtc-at91rm9200.c:448:35: warning: 'at91_rtc_ops' defined but not used [-Wunused-const-variable=] 448 | static const struct rtc_class_ops at91_rtc_ops = { | ^~~~~~~~~~~~ vim +55 include/linux/compiler.h 2bcd521a684cc9 Steven Rostedt 2008-11-21 49 2bcd521a684cc9 Steven Rostedt 2008-11-21 50 #ifdef CONFIG_PROFILE_ALL_BRANCHES 2bcd521a684cc9 Steven Rostedt 2008-11-21 51 /* 2bcd521a684cc9 Steven Rostedt 2008-11-21 52 * "Define 'is'", Bill Clinton 2bcd521a684cc9 Steven Rostedt 2008-11-21 53 * "Define 'if'", Steven Rostedt 2bcd521a684cc9 Steven Rostedt 2008-11-21 54 */ a15fd609ad53a6 Linus Torvalds 2019-03-20 @55 #define if(cond, ...) if ( __trace_if_var( !!(cond , ## __VA_ARGS__) ) ) a15fd609ad53a6 Linus Torvalds 2019-03-20 56 a15fd609ad53a6 Linus Torvalds 2019-03-20 57 #define __trace_if_var(cond) (__builtin_constant_p(cond) ? (cond) : __trace_if_value(cond)) a15fd609ad53a6 Linus Torvalds 2019-03-20 58 a15fd609ad53a6 Linus Torvalds 2019-03-20 59 #define __trace_if_value(cond) ({ \ 2bcd521a684cc9 Steven Rostedt 2008-11-21 60 static struct ftrace_branch_data \ e04462fb82f8dd Miguel Ojeda 2018-09-03 61 __aligned(4) \ 33def8498fdde1 Joe Perches 2020-10-21 62 __section("_ftrace_branch") \ a15fd609ad53a6 Linus Torvalds 2019-03-20 63 __if_trace = { \ 2bcd521a684cc9 Steven Rostedt 2008-11-21 64 .func = __func__, \ 2bcd521a684cc9 Steven Rostedt 2008-11-21 65 .file = __FILE__, \ 2bcd521a684cc9 Steven Rostedt 2008-11-21 66 .line = __LINE__, \ 2bcd521a684cc9 Steven Rostedt 2008-11-21 67 }; \ a15fd609ad53a6 Linus Torvalds 2019-03-20 68 (cond) ? \ a15fd609ad53a6 Linus Torvalds 2019-03-20 69 (__if_trace.miss_hit[1]++,1) : \ a15fd609ad53a6 Linus Torvalds 2019-03-20 70 (__if_trace.miss_hit[0]++,0); \ a15fd609ad53a6 Linus Torvalds 2019-03-20 @71 }) a15fd609ad53a6 Linus Torvalds 2019-03-20 72 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki