On 27/02/2024 14:14:32+0100, A. Sverdlin wrote: > From: Lukas Stockmann <lukas.stockmann@xxxxxxxxxxx> > > From PCF85063A datasheet, section "Software reset": > > "There is a low probability that some devices will have corruption of the > registers after the automatic power-on reset if the device is powered up > with a residual VDD level. It is required that the VDD starts at zero volts > at power up or upon power cycling to ensure that there is no corruption of > the registers. If this is not possible, a reset must be initiated after > power-up (i.e. when power is stable) with the software reset command" > > Trigger SW reset if a power loss is detected. > > Link: https://www.nxp.com/docs/en/data-sheet/PCF85063A.pdf > Signed-off-by: Lukas Stockmann <lukas.stockmann@xxxxxxxxxxx> > Signed-off-by: Alexander Sverdlin <alexander.sverdlin@xxxxxxxxxxx> > --- > drivers/rtc/rtc-pcf85063.c | 19 ++++++++++++++++++- > 1 file changed, 18 insertions(+), 1 deletion(-) > > diff --git a/drivers/rtc/rtc-pcf85063.c b/drivers/rtc/rtc-pcf85063.c > index fdbc07f14036..edfd75d18e19 100644 > --- a/drivers/rtc/rtc-pcf85063.c > +++ b/drivers/rtc/rtc-pcf85063.c > @@ -35,6 +35,7 @@ > #define PCF85063_REG_CTRL1_CAP_SEL BIT(0) > #define PCF85063_REG_CTRL1_STOP BIT(5) > #define PCF85063_REG_CTRL1_EXT_TEST BIT(7) > +#define PCF85063_REG_CTRL1_SWR 0x58 > > #define PCF85063_REG_CTRL2 0x01 > #define PCF85063_CTRL2_AF BIT(6) > @@ -580,7 +581,7 @@ static int pcf85063_probe(struct i2c_client *client) > > i2c_set_clientdata(client, pcf85063); > > - err = regmap_read(pcf85063->regmap, PCF85063_REG_CTRL1, &tmp); > + err = regmap_read(pcf85063->regmap, PCF85063_REG_SC, &tmp); > if (err) { > dev_err(&client->dev, "RTC chip is not present\n"); > return err; > @@ -590,6 +591,22 @@ static int pcf85063_probe(struct i2c_client *client) > if (IS_ERR(pcf85063->rtc)) > return PTR_ERR(pcf85063->rtc); > > + /* > + * If a Power loss is detected, SW reset the device. > + * From PCF85063A datasheet: > + * There is a low probability that some devices will have corruption > + * of the registers after the automatic power-on reset... > + */ > + if (tmp & PCF85063_REG_SC_OS) { > + dev_warn(&client->dev, > + "Power loss detected, send a SW reset to the device\n"); > + err = regmap_write(pcf85063->regmap, PCF85063_REG_CTRL1, > + PCF85063_REG_CTRL1_SWR); > + if (err < 0) > + dev_err(&client->dev, > + "SW reset failed, trying to continue\n"); > + } Doing this in probe is putting a band-aid on a wooden leg as you are not guaranteed you will have a probe to catch this case. This should be rather done in pcf85063_rtc_set_time but it comes with its own set of issues because this probably requires to reconfigure most of the chip which is conveniently done in probe. And then it will introduce varance in the time taken to set_time which is generally bad if you care about sub second precision. -- Alexandre Belloni, co-owner and COO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com
