On 03/11/2022 12:44, Marek Vasut wrote: > On 11/3/22 14:40, Krzysztof Kozlowski wrote: > > [...] > >>> diff --git a/Documentation/devicetree/bindings/rtc/rtc-m41t80.yaml b/Documentation/devicetree/bindings/rtc/rtc-m41t80.yaml >>> new file mode 100644 >>> index 0000000000000..7f31a22caec9b >>> --- /dev/null >>> +++ b/Documentation/devicetree/bindings/rtc/rtc-m41t80.yaml >> >> Filename based on compatibles (more or less), so could be: >> st,m41t80.yaml >> or: >> st,m41txx.yaml >> >> The "rtc" name can be skipped as it is implied from subsystem folder, >> unless st,m41txx is a name of some SoC? > > [...] > >>> + reg: >>> + maxItems: 1 >>> + >>> + interrupts: >>> + maxItems: 1 >>> + >>> + "#clock-cells": >>> + const: 1 >> >> Hm, why do you have it? > > Because of the following warning: > > $ make dt_binding_check > DT_SCHEMA_FILES=Documentation/devicetree/bindings/rtc/rtc-m41t80.yaml > LINT Documentation/devicetree/bindings > DTEX Documentation/devicetree/bindings/rtc/rtc-m41t80.example.dts > CHKDT Documentation/devicetree/bindings/processed-schema.json > Documentation/devicetree/bindings/rtc/rtc-m41t80.yaml: properties: > '#clock-cells' is a dependency of 'clock-output-names' So mention any changes from pure conversion in commit msg. Best regards, Krzysztof
