Re: [PATCH 1/2] dt-bindings: rtc: m41t80: Convert text schema to YAML one

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 11/3/22 14:40, Krzysztof Kozlowski wrote:

[...]

diff --git a/Documentation/devicetree/bindings/rtc/rtc-m41t80.yaml b/Documentation/devicetree/bindings/rtc/rtc-m41t80.yaml
new file mode 100644
index 0000000000000..7f31a22caec9b
--- /dev/null
+++ b/Documentation/devicetree/bindings/rtc/rtc-m41t80.yaml

Filename based on compatibles (more or less), so could be:
st,m41t80.yaml
or:
st,m41txx.yaml

The "rtc" name can be skipped as it is implied from subsystem folder,
unless st,m41txx is a name of some SoC?

[...]

+  reg:
+    maxItems: 1
+
+  interrupts:
+    maxItems: 1
+
+  "#clock-cells":
+    const: 1

Hm, why do you have it?

Because of the following warning:

$ make dt_binding_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/rtc/rtc-m41t80.yaml
  LINT    Documentation/devicetree/bindings
  DTEX    Documentation/devicetree/bindings/rtc/rtc-m41t80.example.dts
  CHKDT   Documentation/devicetree/bindings/processed-schema.json
Documentation/devicetree/bindings/rtc/rtc-m41t80.yaml: properties: '#clock-cells' is a dependency of 'clock-output-names'

+
+  clock-output-names:
+    description: From common clock binding to override the default output clock name.

You need maxItems

Done

+
+  wakeup-source:
+    description: Enables wake up of host system on alarm.

Skip the property - it comes from rtc.yaml.

Done



[Index of Archives]     [Linux Sound]     [ALSA Users]     [ALSA Devel]     [Linux Audio Users]     [Linux Media]     [Kernel]     [Gimp]     [Yosemite News]     [Linux Media]

  Powered by Linux