On 14/09/2022 17.12, Alexandre Belloni wrote: > On 30/08/2022 12:01:52+0200, Rasmus Villemoes wrote: >> Signed-off-by: Rasmus Villemoes <linux@xxxxxxxxxxxxxxxxxx> >> --- >> drivers/rtc/rtc-isl12022.c | 81 ++++++++++++++++++++++++++++++++++++++ >> 1 file changed, 81 insertions(+) >> >> diff --git a/drivers/rtc/rtc-isl12022.c b/drivers/rtc/rtc-isl12022.c >> index b295ec92ee17..1bd72f436318 100644 >> --- a/drivers/rtc/rtc-isl12022.c >> +++ b/drivers/rtc/rtc-isl12022.c >> @@ -17,6 +17,8 @@ >> #include <linux/of.h> >> #include <linux/of_device.h> >> #include <linux/regmap.h> >> +#include <linux/hwmon.h> >> +#include <linux/hwmon-sysfs.h> > > You should keep that list ordered While the three lines of context happen to be sorted, the list as a whole is not. I can of course include a patch sorting it. Rasmus