On 29/09/2021 01:56, Will McVicker wrote: > In order to only modularize the Exynos ARMv8 PMU driver, we have to > split it up from the ARM PMU driver. So make the following Kconfig > changes: > * EXYNOS_PMU -> EXYNOS_PMU_ARM64 > * EXYNOS_PMU_ARM_DRIVERS -> EXYNOS_PMU_ARM > > This patch also includes the necessary modularization changes. > > Lastly, have EXYNOS_PMU_ARM64 use "default y if ARCH_EXYNOS && ARM64" > instead of having ARCH_EXYNOS select it directly. The same comments as for clocks patch: 1. You missed to explain the most important change - removed enforcing of built-in. 2. You ignored Geert's comments and broke distros configs for Exynos platforms. Best regards, Krzysztof
