On 29/09/2021 01:56, Will McVicker wrote: > This sets the COMMON_CLK_SAMSUNG and EXYNOS_ARM64_COMMON_CLK drivers as > tristate so that we can compile them as modules. This is not the only thing you are doing. You are removing the enforced built-in and this must be here explained and tested. The policy so far was that all S3C, S5P and Exynos supported platforms select (enforce) necessary drivers. Please explain in commit msg reasoning why this is being changed and what's the impact (whether it actually works). What is more, it seems you entirely ignored Geert's comments. I pointed attention to it last time and you just said you will send v2 instead of joining discussion. It's a NAK for this reason - ignoring what Geert brought: you just broke distro configs for Exynos. Best regards, Krzysztof
