On 09/25/2020 02:13 PM, WANG Xuerui wrote:
(Re-sending, as the original reply inadvertently contained an HTML part
and has been blocked by all of the mailing lists.)
Hi Huanpeng,
On 2020/9/23 22:31, Du Huanpeng wrote:
rtc-ls2x --> rtc-ls2x-ls7a
RTC_DRV_LS2X --> RTC_DRV_LS2X_LS7A
Loongson LS2X RTC --> Loongson LS2X/LS7A RTC
Maybe the related names include ls7a or LS7A is better to
reflect the reality?
Is there any difference with the rtc IP in loongson 1* SoCs?
From a cursory look at 1A and 7A manuals the registers seem to have the
same layout. Some registers are marked as "reserved" on the 7A manual
while having real meaning on 1A, like the sys_toytrim and sys_rtctrim
registers.
I am investigating whether the rtc_ls1x driver could be worked to
support DT configuration, along with the hardcoded addresses when
compiled for Loongson 1A. If so, adding a separate rtc_ls2x may not be
necessary, rtc_ls1x would be turned into something like rtc_loongson
instead.
Hi Xuerui,
This patch series work well on the Loongson 3A3000 and 3A4000 platform
used with LS7A bridge chip, both read time and write time are OK.
So add:
Tested-by: Tiezhu Yang <yangtiezhu@xxxxxxxxxxx>
And also, since the implementation between rtc_ls1x.c and rtc_ls2x.c
is different, maybe there is no need to add rtc_loongson.c for the
combination of rtc_ls1x.c and rtc_ls2x.c, just leave them as they are.
Thanks,
Tiezhu
