(Re-sending, as the original reply inadvertently contained an HTML part and has been blocked by all of the mailing lists.) Hi Huanpeng, On 2020/9/23 22:31, Du Huanpeng wrote: >> rtc-ls2x --> rtc-ls2x-ls7a >> RTC_DRV_LS2X --> RTC_DRV_LS2X_LS7A >> Loongson LS2X RTC --> Loongson LS2X/LS7A RTC >> >> Maybe the related names include ls7a or LS7A is better to >> reflect the reality? > Is there any difference with the rtc IP in loongson 1* SoCs? >From a cursory look at 1A and 7A manuals the registers seem to have the same layout. Some registers are marked as "reserved" on the 7A manual while having real meaning on 1A, like the sys_toytrim and sys_rtctrim registers. I am investigating whether the rtc_ls1x driver could be worked to support DT configuration, along with the hardcoded addresses when compiled for Loongson 1A. If so, adding a separate rtc_ls2x may not be necessary, rtc_ls1x would be turned into something like rtc_loongson instead. > > Regards, > Du Huanpeng
