On 21/11/2019 09:21:49+0100, Bastian Krause wrote: > > On 11/21/19 9:14 AM, Marek Vasut wrote: > > On 11/21/19 9:09 AM, Bastian Krause wrote: > >> On 9/5/19 3:03 PM, Marek Vasut wrote: > >>> The battery backup can be disabled on this RTC, e.g. if populated right > >>> out of production. Force the battery backup bit on to enable it. > >>> > >>> Signed-off-by: Marek Vasut <marex@xxxxxxx> > >>> Cc: Arnaud Ebalard <arno@xxxxxxxxxxxx> > >>> Cc: Alexandre Belloni <alexandre.belloni@xxxxxxxxxxxxxxxxxx> > >>> Cc: Bastian Krause <bst@xxxxxxxxxxxxxx> > >> > >> Reviewed-by: Bastian Krause <bst@xxxxxxxxxxxxxx> > >> > > > > I recall there was some comment about setting BIT(5) as well, > > RX8130_REG_CONTROL1_CHGEN , can you check that ? > > RX8130_REG_CONTROL1_CHGEN decides whether the battery or the supercap > should be charged or not. I think this patch is okay as is. I'll send a > follow-up patch which will set RX8130_REG_CONTROL1_CHGEN depending on a > new dt-binding "epson,backup-battery-chargeable" once this one is applied. > You need to have a generic RTC property, either reuse trickle-diode-disable (I know the name is a bit unfortunate but that is waht we have) or have a new property stating that the auxiliary voltage is chargeable. using battery in the name is probably not wise because this may as well be a supercap. -- Alexandre Belloni, Bootlin Embedded Linux and Kernel engineering https://bootlin.com
