On 11/21/19 9:21 AM, Bastian Krause wrote: > > On 11/21/19 9:14 AM, Marek Vasut wrote: >> On 11/21/19 9:09 AM, Bastian Krause wrote: >>> On 9/5/19 3:03 PM, Marek Vasut wrote: >>>> The battery backup can be disabled on this RTC, e.g. if populated right >>>> out of production. Force the battery backup bit on to enable it. >>>> >>>> Signed-off-by: Marek Vasut <marex@xxxxxxx> >>>> Cc: Arnaud Ebalard <arno@xxxxxxxxxxxx> >>>> Cc: Alexandre Belloni <alexandre.belloni@xxxxxxxxxxxxxxxxxx> >>>> Cc: Bastian Krause <bst@xxxxxxxxxxxxxx> >>> >>> Reviewed-by: Bastian Krause <bst@xxxxxxxxxxxxxx> >>> >> >> I recall there was some comment about setting BIT(5) as well, >> RX8130_REG_CONTROL1_CHGEN , can you check that ? > > RX8130_REG_CONTROL1_CHGEN decides whether the battery or the supercap > should be charged or not. I think this patch is okay as is. I'll send a > follow-up patch which will set RX8130_REG_CONTROL1_CHGEN depending on a > new dt-binding "epson,backup-battery-chargeable" once this one is applied. Even better, thanks.
