On 2024-11-27 10:45:49 [+0100], Tomas Glozar wrote: > st 27. 11. 2024 v 1:09 odesílatel Crystal Wood <crwood@xxxxxxxxxx> napsal: > > > > This could be said about the laptop and power_management checks too... > > I'd go with verbose info prints rather than warnings for all three, if > > anything. > > > > I agree. I believe my code is consistent with what we already have. > When you do cyclictest --default-system, you also get a warning about > not setting cpu_dma_latency, despite it being what you have explicitly > requested. My patch just does the same thing for --deepest-idle-state. What is the default behaviour and what is the intended behaviour? Couldn't we somehow avoid adding yet another option? > I suggest deferring this to a future patch that would remove the > warnings and another one to refactor the code. Sebastian
