On Wed, 27 Nov 2024, Tomas Glozar wrote: > st 27. 11. 2024 v 1:09 odesílatel Crystal Wood <crwood@xxxxxxxxxx> napsal: > > > > This could be said about the laptop and power_management checks too... > > I'd go with verbose info prints rather than warnings for all three, if > > anything. > > > > I agree. I believe my code is consistent with what we already have. > When you do cyclictest --default-system, you also get a warning about > not setting cpu_dma_latency, despite it being what you have explicitly > requested. My patch just does the same thing for --deepest-idle-state. > > I suggest deferring this to a future patch that would remove the > warnings and another one to refactor the code. > > > I'm not sure how cluttering up main() with more logic would help, but > > turning set_latency_target() into something like > > setup_power()/cleanup_power() sounds good. > > > > -Crystal > > > > Yeah, main() is already long enough, I'd prefer to avoid cluttering it up more. > > Tomas Alright, you convinced me. Signed-off-by: John Kacur <jkacur@xxxxxxxxxx>
