On 19/02/24 10:55, Kuniyuki Iwashima wrote: > From: Valentin Schneider <vschneid@xxxxxxxxxx> >> @@ -53,16 +53,14 @@ void dccp_time_wait(struct sock *sk, int state, int timeo) >> if (state == DCCP_TIME_WAIT) >> timeo = DCCP_TIMEWAIT_LEN; >> >> - /* tw_timer is pinned, so we need to make sure BH are disabled >> - * in following section, otherwise timer handler could run before >> - * we complete the initialization. >> - */ >> - local_bh_disable(); >> - inet_twsk_schedule(tw, timeo); >> - /* Linkage updates. >> - * Note that access to tw after this point is illegal. >> - */ >> + local_bh_disable(); > > This line seems not correctly indented, same for TCP change. > > > >> + >> + // Linkage updates >> inet_twsk_hashdance(tw, sk, &dccp_hashinfo); >> + inet_twsk_schedule(tw, timeo); >> + // Access to tw after this point is illegal. > > Also please use /**/ style for these comments, same for TCP too. > Will do, thanks!
