On Wed, 18 Oct 2023, Mathias Krause wrote:
> On 26.09.23 13:04, Mathias Krause wrote:
> > Commit 974241c78a6f ("rt-tests: Makefile: ctags: Change obsolete extra to
> > extras") not only broke the generation of tags files -- at least for exuberant
> > ctags version 5.9 as shipped in Debian -- but it also added -Wextra to CFLAGS,
> > leading to many warnings.
> >
> > Simply revert the commit to undo the unintended change and unbreak ctags file
> > generation.
> >
> > Signed-off-by: Mathias Krause <minipli@xxxxxxxxxxxxxx>
> > ---
> > Makefile | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/Makefile b/Makefile
> > index 32a9f41198a4..3b9e90d528e5 100644
> > --- a/Makefile
> > +++ b/Makefile
> > @@ -30,7 +30,7 @@ prefix ?= /usr/local
> > bindir ?= $(prefix)/bin
> > mandir ?= $(prefix)/share/man
> >
> > -CFLAGS ?= -Wall -Wno-nonnull -Wextra
> > +CFLAGS ?= -Wall -Wno-nonnull
> > CPPFLAGS += -D_GNU_SOURCE -Isrc/include
> > LDFLAGS ?=
> >
> > @@ -253,4 +253,4 @@ help:
> >
> > .PHONY: tags
> > tags:
> > - ctags -R --extras=+f --c-kinds=+p --exclude=tmp --exclude=BUILD *
> > + ctags -R --extra=+f --c-kinds=+p --exclude=tmp --exclude=BUILD *
>
>
> Ping?
>
> Can this be merged to fix ctags, at least?:
Sorry, but the problem is that Debian is using an
old version of ctags. You can either just edit the Makefile to build on
Debian, or compile a more modern version of ctags by hand, I'm sure there
are some other solutions as well.
As for the warnings, we want to see those. People including myself have
sent in patches to fix the cause of the warnings, but simply hiding them
isn't the solution.
Thanks
John
