Re: [PATCH] Revert "rt-tests: Makefile: ctags: Change obsolete extra to extras"

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 26.09.23 13:04, Mathias Krause wrote:
> Commit 974241c78a6f ("rt-tests: Makefile: ctags: Change obsolete extra to
> extras") not only broke the generation of tags files -- at least for exuberant
> ctags version 5.9 as shipped in Debian -- but it also added -Wextra to CFLAGS,
> leading to many warnings.
> 
> Simply revert the commit to undo the unintended change and unbreak ctags file
> generation.
> 
> Signed-off-by: Mathias Krause <minipli@xxxxxxxxxxxxxx>
> ---
>  Makefile | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/Makefile b/Makefile
> index 32a9f41198a4..3b9e90d528e5 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -30,7 +30,7 @@ prefix  ?= /usr/local
>  bindir  ?= $(prefix)/bin
>  mandir	?= $(prefix)/share/man
>  
> -CFLAGS ?= -Wall -Wno-nonnull -Wextra
> +CFLAGS ?= -Wall -Wno-nonnull
>  CPPFLAGS += -D_GNU_SOURCE -Isrc/include
>  LDFLAGS ?=
>  
> @@ -253,4 +253,4 @@ help:
>  
>  .PHONY: tags
>  tags:
> -	ctags -R --extras=+f --c-kinds=+p --exclude=tmp --exclude=BUILD *
> +	ctags -R --extra=+f --c-kinds=+p --exclude=tmp --exclude=BUILD *


Ping?

Can this be merged to fix ctags, at least?:

minipli@bell:~/src/upstream/rt-tests ((v2.6))$ make tags
ctags -R --extras=+f --c-kinds=+p --exclude=tmp --exclude=BUILD *
ctags: Unknown option: --extras
make: *** [Makefile:256: tags] Fehler 1
minipli@bell:~/src/upstream/rt-tests ((v2.6))$ ctags --version
Exuberant Ctags 5.9~svn20110310, Copyright (C) 1996-2009 Darren Hiebert
  Addresses: <dhiebert@xxxxxxxxxxxxxxxxxxxxx>, http://ctags.sourceforge.net
  Optional compiled features: +wildcards, +regex

Thanks,
Mathias




[Index of Archives]     [RT Stable]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Video 4 Linux]     [Device Mapper]

  Powered by Linux