Re: [PATCH rt-tests 1/2] oslat: Print version string

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Feb 10, 2021 at 07:15:04PM +0100, Daniel Wagner wrote:
> > It's great idea to have JSON format for all the tools.  However I just don't
> > see why "-v"/"--version" is related to your machine readable output work.
> > Could you exlaborate?  Thanks,
> 
> I've added long options support to many rt-tests in the mentioned
> series. I would like to base this fix on top of this work.

My opinion probably don't even matter here... but I tend to agree with John
that the fix and your work is separated.  If there's must a rebase, it would be
better to rebase the big series upon the fix rather than the other way round,
simply because a fix is normally more important than a new feature (if not
talking about this "-v" thing, the other --cpu-list issue should be important).

Appreciate all the refactoring works on oslat happened and ongoing, it would
just be even nicer if the touched code path can be smoked so we don't miss
anything important.

Thanks again.

-- 
Peter Xu




[Index of Archives]     [RT Stable]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Video 4 Linux]     [Device Mapper]

  Powered by Linux