On Wed, 10 Feb 2021, Daniel Wagner wrote:
> During the streamlining of the command line options we missed to hook
> up the command line option '--version' with usage().
>
> Fixes: e411219d27b1 ("oslat: Streamline usage output and man page")
> Reported-by: Peter Xu <peterx@xxxxxxxxxx>
> Signed-off-by: Daniel Wagner <dwagner@xxxxxxx>
> ---
> src/oslat/oslat.c | 8 +-------
> 1 file changed, 1 insertion(+), 7 deletions(-)
>
> diff --git a/src/oslat/oslat.c b/src/oslat/oslat.c
> index 5b7e0d5b5d5c..d3f659b218b0 100644
> --- a/src/oslat/oslat.c
> +++ b/src/oslat/oslat.c
> @@ -655,16 +655,10 @@ static void parse_options(int argc, char *argv[])
> */
> g.single_preheat_thread = true;
> break;
> - case 'v':
> - /*
> - * Because we always dump the version even before parsing options,
> - * what we need to do is to quit..
> - */
> - exit(0);
> - break;
> case 'z':
> g.output_omit_zero_buckets = 1;
> break;
> + case 'v':
> case 'h':
> usage(0);
> break;
> --
> 2.30.0
>
>
It shouldn't be a fall through, we don't want to print the usage.
