Re: [PATCH v5.6.4-rt3] rfcomm/bluetooth: avoid disabling interrupts on RT

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, May 27, 2020 at 11:48:58AM +0200, Sebastian Andrzej Siewior wrote:
> On 2020-04-23 16:31:55 [-0300], Luis Claudio R. Goncalves wrote:
> …
> > Replacing local_irq_save()/bh_lock_sock() by spin_lock_bh() keeps the semantics
> > and does the right thing under PREEMPT_RT.
> 
> Nope. The irq-off was introduced in commit
>    fad003b6c8e3d ("Bluetooth: Fix inconsistent lock state with RFCOMM")
> 
> It doesn't look right. Could you please revert that commit and check if
> lockdep still complains?

Thanks, Sebastian! I built a kernel with commit fad003b6c8e3d reverted and
the lockdep complaints are gone.

Luis




[Index of Archives]     [RT Stable]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Video 4 Linux]     [Device Mapper]

  Powered by Linux