On Tue, 11 Feb 2020 22:28:56 -0500 Steven Rostedt <rostedt@xxxxxxxxxxx> wrote: > On Wed, 12 Feb 2020 12:24:15 +0900 > Masami Hiramatsu <mhiramat@xxxxxxxxxx> wrote: > > > On Mon, 10 Feb 2020 17:06:49 -0600 > > Tom Zanussi <zanussi@xxxxxxxxxx> wrote: > > > > > There's no reason to return -EINVAL when tracing a synthetic event if > > > it's soft disabled - treat it the same as if it were hard disabled and > > > return normally. > > > > > > Have synth_event_trace() and synth_event_trace_array() just return > > > normally, and have synth_event_trace_start set the trace state to > > > disabled and return. > > > > > > > Looks good to me. > > > > Reviewed-by: Masami Hiramatsu <mhiramat@xxxxxxxxxx> > > > > Thanks for the review Masami, but these patches have already landed in > Linus's tree ;-) Oh, OK. But I think [3/3] still has a real bug (not checking state->disabled in __synth_event_trace_end()). I'll send a fix. Thank you, -- Masami Hiramatsu <mhiramat@xxxxxxxxxx>
