Hi Steve, I noticed a couple bugs while creating a patch consolidating the synthetic event trace() functions. Here are the two bugfixes along with the consolidated trace patch. The first patch adds a missing ring_buffer_nest_end() in an error case, and the second removes unnecessary error returns when an event is soft disabled. The third patch consolidates the common code in synth_event_trace_array(), synth_event_trace() and synth_event_trace_start(). Thanks, Tom The following changes since commit 7a1f8097178832627261a16e32973b12a0355dad: bootconfig: Use parse_args() to find bootconfig and '--' (2020-02-07 20:51:08 -0500) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/zanussi/linux-trace.git ftrace/synth-event-gen-fixes-v1 Tom Zanussi (3): tracing: Add missing nest end to synth_event_trace_start() error case tracing: Don't return -EINVAL when tracing soft disabled synth events tracing: Consolidate trace() functions include/linux/trace_events.h | 2 +- kernel/trace/trace_events_hist.c | 227 +++++++++++++++------------------------ 2 files changed, 87 insertions(+), 142 deletions(-) -- 2.14.1