On Wed, 2018-12-19 at 21:27 +0900, Masami Hiramatsu wrote: > Hi Tom, > > On Tue, 18 Dec 2018 14:33:19 -0600 > Tom Zanussi <zanussi@xxxxxxxxxx> wrote: > > > From: Tom Zanussi <tom.zanussi@xxxxxxxxxxxxxxx> > > > > Hi, > > > > This patchset is a standalone series broken out of the v8 version > > of > > the 'tracing: Hist trigger snapshot and onchange additions' > > patchset. > > > > It's a series of changes resulting from some suggestions from > > Namhyung > > for making the variable-reference handling code more understandable > > through some refactoring and comments. > > > > It also added a new patch changing all strlen() to sizeof() for > > string > > constants, in trace_events_hist.c > > > > Also, in the 'tracing: Remove open-coding of hist trigger var_ref > > management' patch, in create_var_ref(), moved the saving of > > ref_field > > and update of ref_field->var_ref_idx into the 'if' as pointed out > > by > > Dan Carpenter/smatch 0-day robot. > > > > It doesn't introduce any functional changes and can be applied > > independently of the other patchset. > > OK, now it is very clear to me :-) > > Reviewed-by: Masami Hiramatsu <mhiramat@xxxxxxxxxx> > > for the series. > Thanks, Masami! Tom