Hi Tom, On Tue, 18 Dec 2018 14:33:19 -0600 Tom Zanussi <zanussi@xxxxxxxxxx> wrote: > From: Tom Zanussi <tom.zanussi@xxxxxxxxxxxxxxx> > > Hi, > > This patchset is a standalone series broken out of the v8 version of > the 'tracing: Hist trigger snapshot and onchange additions' patchset. > > It's a series of changes resulting from some suggestions from Namhyung > for making the variable-reference handling code more understandable > through some refactoring and comments. > > It also added a new patch changing all strlen() to sizeof() for string > constants, in trace_events_hist.c > > Also, in the 'tracing: Remove open-coding of hist trigger var_ref > management' patch, in create_var_ref(), moved the saving of ref_field > and update of ref_field->var_ref_idx into the 'if' as pointed out by > Dan Carpenter/smatch 0-day robot. > > It doesn't introduce any functional changes and can be applied > independently of the other patchset. OK, now it is very clear to me :-) Reviewed-by: Masami Hiramatsu <mhiramat@xxxxxxxxxx> for the series. Thank you, > > Tom > > > The following changes since commit 5d6ddf6acce68d1290112cb08b12fd78b201e7d5: > > arm64: Use ftrace_graph_get_ret_stack() instead of curr_ret_stack (2018-12-08 22:21:31 -0500) > > are available in the git repository at: > > git://git.kernel.org/pub/scm/linux/kernel/git/zanussi/linux-trace.git ftrace/hist-var-ref-cleanup-v1 > > Tom Zanussi (7): > tracing: Remove unnecessary hist trigger struct field > tracing: Change strlen to sizeof for hist trigger static strings > tracing: Use var_refs[] for hist trigger reference checking > tracing: Remove open-coding of hist trigger var_ref management > tracing: Use hist trigger's var_ref array to destroy var_refs > tracing: Remove hist trigger synth_var_refs > tracing: Add hist trigger comments for variable-related fields > > kernel/trace/trace_events_hist.c | 267 +++++++++++++++++++++++---------------- > 1 file changed, 156 insertions(+), 111 deletions(-) > > -- > 2.14.1 > -- Masami Hiramatsu <mhiramat@xxxxxxxxxx>
