John,
Luis and I were working on our tests and decided it is more interesting, in our
automated tests, to have a higher tolerance for SMIs, as most of the test boxes are
not optimized for RT. On the other hand, we would like to know how big the firmware-induced
latencies on these boxes.
This commit adds the --hardlimit parameter, which defines the real
PASS/FAIL latency criteria. Latencies above --threshold will be
annotated, but the test may PASS if the observed latencies are smaller
than --hardlimit.
When --hardlimit is not informed, the value used for --threshold is also
used as the hard limit.
Signed-off-by: Luis Claudio R. Goncalves <lgoncalv@xxxxxxxxxx>
Signed-off-by: Clark Williams <williams@xxxxxxxxxx>
diff --git a/hwlatdetect.py b/hwlatdetect.py
index d9ef027..51bb401 100755
--- a/hwlatdetect.py
+++ b/hwlatdetect.py
@@ -474,6 +474,10 @@ if __name__ == '__main__':
dest="threshold",
help="value above which is considered an hardware latency")
+ parser.add_option("--hardlimit", default=None, type="string",
+ dest="hardlimit",
+ help="value above which the test is considered to fail")
+
parser.add_option("--window", default=None, type="string",
dest="window",
help="time between samples")
@@ -526,6 +530,12 @@ if __name__ == '__main__':
detect.set("threshold", t)
debug("threshold set to %dus" % t)
+ if o.hardlimit:
+ hardlimit = microseconds(o.hardlimit)
+ else:
+ hardlimit = detect.get("threshold")
+ debug("hardlimit set to %dus" % hardlimit)
+
if o.window:
w = microseconds(o.window)
if w < detect.get("width"):
@@ -595,5 +605,6 @@ if __name__ == '__main__':
for s in detect.samples:
print("%s" % s)
+ maxlatency = int(detect.get("max"))
detect.cleanup()
- sys.exit(exceeding)
+ sys.exit(maxlatency > hardlimit)
--
The United States Coast Guard:
Ruining natural selection since 1790
Attachment:
pgpa7RXDQe9Yx.pgp
Description: OpenPGP digital signature
