Re: [patch 2/3] cyclictest: Convert the offset of the alignment option to microseconds

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On Sat, 30 May 2015, Anna-Maria Gleixner wrote:

> On 2015-05-27 23:32, John Kacur wrote:
> > On Tue, 26 May 2015, anna-maria@xxxxxxxxx wrote:
> > Don't we need the conversion here too then?
> > >  				offset = atoi(argv[optind]);
> 
> Jap, this is right. I forgot it. I changed the patch.
> I forgot the same in the third patch of this series. I'll fix it and send the
> patch back to you.
> 
> 	Anna-Maria
> 
> 
> The offset is specified in microseconds according to the
> documentation, but, the microseconds to nanoseconds conversion is
> missing so the effective offset has the unit of nanoseconds.
> 
> Signed-off-by: Anna-Maria Gleixner <anna-maria@xxxxxxxxx>
> ---
>  src/cyclictest/cyclictest.c |    4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> Index: rt-tests/src/cyclictest/cyclictest.c
> ===================================================================
> --- rt-tests.orig/src/cyclictest/cyclictest.c
> +++ rt-tests/src/cyclictest/cyclictest.c
> @@ -1289,9 +1289,9 @@ static void process_options (int argc, c


I fixed your patch manually, but you are doing something wrong generating 
it, see how the function header get's cut off above there?


>  		case OPT_ALIGNED:
>  			aligned=1;
>  			if (optarg != NULL)
> -				offset = atoi(optarg);
> +				offset = atoi(optarg) * 1000;
>  			else if (optind<argc && atoi(argv[optind]))
> -				offset = atoi(argv[optind]);
> +				offset = atoi(argv[optind]) * 1000;
>  			else
>  				offset = 0;
>  			break;
> --
> To unsubscribe from this list: send the line "unsubscribe linux-rt-users" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-rt-users" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [RT Stable]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Video 4 Linux]     [Device Mapper]

  Powered by Linux