On Tue, 26 May 2015 10:43:43 -0500 Clark Williams <williams@xxxxxxxxxx> wrote: > On Tue, 26 May 2015 11:19:24 -0400 > Steven Rostedt <rostedt@xxxxxxxxxxx> wrote: > > > On Tue, 26 May 2015 08:48:02 -0500 > > Clark Williams <williams@xxxxxxxxxx> wrote: > > > > > > > Change the WARN_ON to WARN_ON_NORT > > > > Do we have a WARN_ON_NORT? I see a WARN_ON_NONRT, but not a > > WARN_ON_NORT. Does this compile? > > > > -- Steve > > Sigh. Of course not. Reupdated patch (and yes this one compiles): > > From: Clark Williams <williams@xxxxxxxxxx> > Date: Thu, 21 May 2015 12:51:53 -0500 > Subject: [PATCH] [rt] i915: bogus warning from i915 when running on > PREEMPT_RT > > The i915 driver has a 'WARN_ON(!in_interrupt())' in the display > handler, which whines constanly on the RT kernel (since the interrupt > is actually handled in a threaded handler and not actual interrupt > context). > > Change the WARN_ON to WARN_ON_NORT > > Signed-off-by: Clark Williams <williams@xxxxxxxxxx> > --- > drivers/gpu/drm/i915/intel_display.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/i915/intel_display.c > b/drivers/gpu/drm/i915/intel_display.c index > f75173c20f47..30b1d16caa0d 100644 --- > a/drivers/gpu/drm/i915/intel_display.c +++ > b/drivers/gpu/drm/i915/intel_display.c @@ -9745,7 +9745,7 @@ void > intel_check_page_flip(struct drm_device *dev, int pipe) struct > drm_crtc *crtc = dev_priv->pipe_to_crtc_mapping[pipe]; struct > intel_crtc *intel_crtc = to_intel_crtc(crtc); > - WARN_ON(!in_interrupt()); > + WARN_ON_NONRT(!in_interrupt()); > > if (crtc == NULL) > return; You can add my Tested-by: Joakim Hernberg <jhernberg@xxxxxxxxxx>. Seems to fix the problem on my systems too. -- Joakim -- To unsubscribe from this list: send the line "unsubscribe linux-rt-users" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
