On Tue, 26 May 2015 09:38:32 -0400 Steven Rostedt <rostedt@xxxxxxxxxxx> wrote: > On Tue, 26 May 2015 08:34:49 -0500 > Clark Williams <williams@xxxxxxxxxx> wrote: > > > diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c > > index f75173c20f47..f532b22f56ba 100644 > > --- a/drivers/gpu/drm/i915/intel_display.c > > +++ b/drivers/gpu/drm/i915/intel_display.c > > @@ -9745,7 +9745,9 @@ void intel_check_page_flip(struct drm_device *dev, int pipe) > > struct drm_crtc *crtc = dev_priv->pipe_to_crtc_mapping[pipe]; > > struct intel_crtc *intel_crtc = to_intel_crtc(crtc); > > > > +#ifndef CONFIG_PREEMPT_RT_FULL > > WARN_ON(!in_interrupt()); > > +#endif > > Or just use our special WARN_ON() functions... > > > WARN_ON_NONRT(!in_interrupt()); > > -- Steve good point. Updated patch: From: Clark Williams <williams@xxxxxxxxxx> Date: Thu, 21 May 2015 12:51:53 -0500 Subject: [PATCH] [rt] i915: bogus warning from i915 when running on PREEMPT_RT The i915 driver has a 'WARN_ON(!in_interrupt())' in the display handler, which whines constanly on the RT kernel (since the interrupt is actually handled in a threaded handler and not actual interrupt context). Change the WARN_ON to WARN_ON_NORT Signed-off-by: Clark Williams <williams@xxxxxxxxxx> --- drivers/gpu/drm/i915/intel_display.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c index f75173c20f47..b21e3a334e4e 100644 --- a/drivers/gpu/drm/i915/intel_display.c +++ b/drivers/gpu/drm/i915/intel_display.c @@ -9745,7 +9745,7 @@ void intel_check_page_flip(struct drm_device *dev, int pipe) struct drm_crtc *crtc = dev_priv->pipe_to_crtc_mapping[pipe]; struct intel_crtc *intel_crtc = to_intel_crtc(crtc); - WARN_ON(!in_interrupt()); + WARN_ON_NORT(!in_interrupt()); if (crtc == NULL) return; -- 2.1.0 -- To unsubscribe from this list: send the line "unsubscribe linux-rt-users" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
