2009/6/8 Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx>: >> Signed-off-by: GeunSik Lim <geunsik.lim@xxxxxxxxxxx> >> Reviewed-by : Luis Claudio R. Goncalves <lclaudio@xxxxxxxx> > hhm, I don't know how Clark handles these flags, but I wouldn't count > the comments by Luis Claudio R. Goncalves as review. Still more as you > didn't follow his advice and I would only add this tag after the > reviewer is OK with the result. > <nitpick> > In the kernel the colons and names usually are not aligned. > </nitpick> Thank you for your advice and opinion about my trivital patch. Sorry. Maybe, I mistooked about how to append "Reviewed-by tag". >> + * mountpoint of debugfs filesystem. >> + * - debugfs related reference: http://lwn.net/Articles/334546/ > set_debugfileprefix doesn't depend on a "default mountpoint", it parses > /proc/mounts, so it should even work if you mount it somewhere below /home. > And I'm not convinced that adding a link to lwn is a good idea. I would > expect that the normal cyclictest hacker knows about debugfs. Yes, It's correct. But, I think that a detailed remark is not bad. > > So what about simply > > + * Finds the tracing directory in a mounted debugfs. > > ? Ah, just see that is similar to the suggestion by Luis Claudio R. > Goncalves. Your comment is also correct. Anyway, I want Clark to edit "debugfs/tracing" comment with a suitable expression normally. -- Regards, GeunSik Lim ( Samsung Electronics ) Blog : http://blog.naver.com/invain/ e-Mail: geunsik.lim@xxxxxxxxxxx leemgs@xxxxxxxxx , leemgs1@xxxxxxxxx -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ -- To unsubscribe from this list: send the line "unsubscribe linux-rt-users" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
