Hi All, Anyone have opinion about below contents that I sent previously? I want to discuss and fix about duplicated description of -h option after "#> cyclictest --help"command. If I mistake , Correct me. Thanks Reading. Regards, GeunSik , Lim 2009-04-24 (Fri), 09:13 +0900, GeunSik Lim wrote: > Dear Clark Williams, > > I submitted trivial patch about "cyclictest --help" command. > Can you check patch about duplication display about "-h" option of > "cyclictest --help" command? > > for example, > #> cyclictest --help [enter] > -h H_MAX latency histogram size in us default 0 (off) > -h --histogram=US dump a latency histogram to stdout after the run > US is the max time to be be tracked in microseconds > > > > Thanks reading. > > > > Regards, > GeunSik Lim, > > > 2009-04-21 (È), 16:29 +0900, GeunSik Lim ¾²½Ã±æ: > > Author: Lim,GeunSik <leemgs1@xxxxxxxxx> > > Date: Tue Apr 21 16:03:56 2009 +0900 > > > > [PATCH] cyclictest: Remove duplicated description of cyclictest usage like -h. > > > > We often utilize a various options with "#>cyclictest --help" command in the terminal environment. > > When We run "#> cyclictest --help" command, We can show duplicated description about "-h" option > > for latency histogram. > > Unfortunatley, Some of the users is confusing because of two options about latency histogram. > > > > [root@fedora9 invain]# ./cyclictest --help > > cyclictest V 0.36 > > Usage: > > cyclictest <options> > > > > -a [NUM] --affinity run thread #N on processor #N, if possible > > with NUM pin all threads to the processor NUM > > -b USEC --breaktrace=USEC send break trace command when latency > USEC > > -B --preemptirqs both preempt and irqsoff tracing (used with -b) > > -c CLOCK --clock=CLOCK select clock > > 0 = CLOCK_MONOTONIC (default) > > 1 = CLOCK_REALTIME > > -C --context context switch tracing (used with -b) > > -d DIST --distance=DIST distance of thread intervals in us default=500 > > -E --event event tracing (used with -b) > > -f --ftrace function trace (when -b is active) > > -h H_MAX latency histogram size in us default 0 (off) > > -i INTV --interval=INTV base interval of thread in us default=1000 > > > > ................. [Middle Omission] ................... > > > > -v --verbose output values on stdout for statistics > > format: n:c:v n=tasknum c=count v=value in us > > -D --duration=t specify a length for the test run > > default is in seconds, but 'm', 'h', or 'd' maybe added > > to modify value to minutes, hours or days > > -h --histogram=US dump a latency histogram to stdout after the run > > US is the max time to be be tracked in microseconds > > > > For example, > > > > -h H_MAX latency histogram size in us default 0 (off) > > > > -h --histogram=US dump a latency histogram to stdout after the run > > US is the max time to be be tracked in microseconds > > > > As you see, We don't need "-h H_MAX . . . . . ." description. > > So, I think that We have to remove old option about description of histogram function. > > > > Signed-off-by: GeunSik Lim <leemgs1@xxxxxxxxx> > > --- > > src/cyclictest/cyclictest.c | 1 - > > 1 files changed, 0 insertions(+), 1 deletions(-) > > > > diff --git a/src/cyclictest/cyclictest.c b/src/cyclictest/cyclictest.c > > index 1660893..884f2c3 100644 > > --- a/src/cyclictest/cyclictest.c > > +++ b/src/cyclictest/cyclictest.c > > @@ -688,7 +688,6 @@ static void display_help(void) > > "-d DIST --distance=DIST distance of thread intervals in us default=500\n" > > "-E --event event tracing (used with -b)\n" > > "-f --ftrace function trace (when -b is active)\n" > > - "-h H_MAX latency histogram size in us default 0 (off)\n" > > "-i INTV --interval=INTV base interval of thread in us default=1000\n" > > "-I --irqsoff Irqsoff tracing (used with -b)\n" > > "-l LOOPS --loops=LOOPS number of loops: default=0(endless)\n" > > > > > > ----------------------------------------------- > > To unsubscribe from this list: send the line "unsubscribe linux-***" > > in the body of a message to majordomo@xxxxxxxxxxxxxxx > > More majordomo info at http://vger.kernel.org/majordomo-info.html > > Please read the FAQ at http://www.tux.org/lkml/ > > > > GeunSik Lim (ELS - OS Group - S/W Lab - SAIT - SAMSUNG) > > e-Mail :1) geunsik.lim@xxxxxxxxxxx > > 2) leemgs@xxxxxxxxx , leemgs1@xxxxxxxxx > > HomePage: http://intomail.dnip.net/invain/me/ > > ----------------------------------------------- -- ----------------------------------------------- To unsubscribe from this list: send the line "unsubscribe linux-***" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ GeunSik Lim (ELS - OS Group - S/W Lab - SAIT - SAMSUNG) e-Mail :1) geunsik.lim@xxxxxxxxxxx 2) leemgs@xxxxxxxxx , leemgs1@xxxxxxxxx HomePage: http://intomail.dnip.net/invain/me/ ----------------------------------------------- -- To unsubscribe from this list: send the line "unsubscribe linux-rt-users" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
