Re: [PATCH] fix argument -C on cyclictest

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Uwe Kleine-Konig

I already submited same issues.  for example, --context  and --event.
Is your patch proposal is different?

Refer to  http://marc.info/?l=linux-rt-users&m=123919858213957&w=2 webpage.


Regards,
GeunSik Lim.


2009/4/20 Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx>:
> Hi,
>
> On Sun, Apr 19, 2009 at 05:09:25PM +0200, trem wrote:
>> The argument -C isn't used in cyclictest, only --context is recognized.
>>
>> Signed-off-by: trem <trem@xxxxxxxxxxxx>
>> ---
>> diff --git a/src/cyclictest/cyclictest.c b/src/cyclictest/cyclictest.c
>> index f878217..e67d0d3 100644
>> --- a/src/cyclictest/cyclictest.c
>> +++ b/src/cyclictest/cyclictest.c
>> @@ -777,7 +777,7 @@ static void process_options (int argc, char *argv[])
>>                        {"help", no_argument, NULL, '?'},
>>                        {NULL, 0, NULL, 0}
>>                };
>> -               int c = getopt_long (argc, argv, "a::b:Bc:d:fh:i:Il:nNo:p:Pmqrst::vD:",
>> +               int c = getopt_long (argc, argv, "a::b:Bc:Cd:fh:i:Il:nNo:p:Pmqrst::vD:",
>>                        long_options, &option_index);
> After the commit log I would have expected that you remove C from the
> options list.  I would suggest something like "make cyclictest accept -C
> as documented.  This is the same as --context".
>
> BTW, I just noticed that both -C and --context don't appear in the man
> page.
>
> Best regards
> Uwe
>
> --
> Pengutronix e.K.                              | Uwe Kleine-König            |
> Industrial Linux Solutions                    | http://www.pengutronix.de/  |
> --
> To unsubscribe from this list: send the line "unsubscribe linux-rt-users" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>



-- 
Regards,
GeunSik Lim
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/
--
To unsubscribe from this list: send the line "unsubscribe linux-rt-users" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [RT Stable]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Video 4 Linux]     [Device Mapper]

  Powered by Linux