[PATCH-rt26] irq handle: use cached status instead of dereference NULL action

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Patch "irq-tracer-fix.patch" from the additions at rt13 of the
26 preempt_rt patch set introduced a test on action->flags, but it
comes at the end of a loop where we will have run all the
chained handlers until action==NULL.  Since we have stored the
action->flags (or'd) in status while walking the action chain,
use status in the check instead.

Signed-off-by: Paul Gortmaker <paul.gortmaker@xxxxxxxxxxxxx>
---
 kernel/irq/handle.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/kernel/irq/handle.c b/kernel/irq/handle.c
index ed6deaa..314c9d7 100644
--- a/kernel/irq/handle.c
+++ b/kernel/irq/handle.c
@@ -164,7 +164,7 @@ irqreturn_t handle_IRQ_event(unsigned int irq, struct irqaction *action)
 	} while (action);
 
 	if (status & IRQF_SAMPLE_RANDOM) {
-		if (hardirq_count() && (action->flags & IRQF_DISABLED))
+		if (hardirq_count() && (status & IRQF_DISABLED))
 			local_irq_enable();
 		add_interrupt_randomness(irq);
 	}
-- 
1.6.0.4

--
To unsubscribe from this list: send the line "unsubscribe linux-rt-users" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [RT Stable]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Video 4 Linux]     [Device Mapper]

  Powered by Linux