Re: [PATCH][RT]: handle_IRQ_event() - fix thinko

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, 23 Sep 2008, Sebastien Dugue wrote:

> 
>   handle_IRQ_event() reenables interrupts for threaded IRQ handlers,
> provided said handler does not need to run with IRQF_DISABLED.
> 
>   Therefore, unless I'm missing something, in the following:
> 
> if (!hardirq_count() || !(action->flags & IRQF_DISABLED))
> 	local_irq_enable();
> 
>   the logical OR should be a logical AND:
> 
> if (!hardirq_count() && !(action->flags & IRQF_DISABLED))
> 	local_irq_enable();

No. We don't want to run the threaded handler with interrupts disabled.

!hardirq_count() tells us that we are in thread context.
 
>   Or maybe I've not yet reached my daily cafeine dose. (Damned addiction)

Looks like. :)

Thanks,

	tglx
--
To unsubscribe from this list: send the line "unsubscribe linux-rt-users" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [RT Stable]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Video 4 Linux]     [Device Mapper]

  Powered by Linux