Re: [PATCH] ftrace: Actually call function pointer in ftrace_stop

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



(CC'd Ingo and Thomas)

On Tue, 15 Jul 2008, Josh Triplett wrote:

>
> ftrace_stop used a function pointed as a no-op expression, rather than
> actually calling it.
>
> Signed-off-by: Josh Triplett <josh@xxxxxxxxxx>
> ---
>  kernel/trace/trace.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/kernel/trace/trace.c b/kernel/trace/trace.c
> index 0a38f84..5f7f421 100644
> --- a/kernel/trace/trace.c
> +++ b/kernel/trace/trace.c
> @@ -3283,7 +3283,7 @@ void ftrace_stop(void)
>  	if (tr->ctrl) {
>  		tr->ctrl = 0;
>  		if (saved_tracer && saved_tracer->ctrl_update)
> -			saved_tracer->ctrl_update;
> +			saved_tracer->ctrl_update(tr);
>  	}
>
>

Good catch. This patch is for -rt only. It covers a change I did for
Thomas. Thomas is currently handling the 24 and 25 queues.

-- Steve

P.S. You should CC lkml too, but make sure you use [PATCH RT] to
differentiate it from mainline patches.

--
To unsubscribe from this list: send the line "unsubscribe linux-rt-users" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [RT Stable]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Video 4 Linux]     [Device Mapper]

  Powered by Linux