On Fri, 27 Jun 2008, John Kacur wrote: > On Fri, Jun 27, 2008 at 6:06 PM, Clark Williams > <clark.williams@xxxxxxxxx> wrote: > > -----BEGIN PGP SIGNED MESSAGE----- > > Hash: SHA1 > > > > Steven Rostedt wrote: > >> 5B > >> > >> On Fri, 27 Jun 2008, Leon Woestenberg wrote: > >> > >>> Hello, > >>> > >>> I still found it strange that the RTWiki mentions "-t NUM" as if it > >>> works, so the manual page of cyclictest and the wiki needs a review > >>> too. > >> > >> It doesn't? > >> > >> Then again I must have an old version of cyclictest, because both -t5 and > >> -t 5 work for me. > >> > >> -- Steve > >> > > > > You do. The current source in Thomas's git tree exhibits this > > behavior, because of the way getopt() handles optional arguments. > > > > Clark > > Right the extra-code is only necessary for the processing of optional > arguments, so without checking the history of the program, I would > assume that the NUM argument to -t was not optional in the past. Now > it is optional because -t without arguments implies threads = > max_cpus. I made some very minor edits to the wiki a little while ago > to reflect this but the Wiki page does need to updated more, I think > the usage file corresponds a lot more closely to the actual behaviour. > > crap, I see I left of the signed-off-by: John Kacur <jkacur@xxxxxxxxx> > line on the patch, do I need to resubmit it? Grmbl, was going to ask that, but did not find you on IRC and I committed it _before_ reading this mail. I applied it with two tweaks: 1) Your patch was line wrapped :( 2) I fixed the info for -a NUM. We pin the threads to exactly the CPU specified with NUM Pushed out to git and released 0.23. Thanks, tglx -- To unsubscribe from this list: send the line "unsubscribe linux-rt-users" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
