Re: [PATCH] Fix the processing of optional options for cyclictest

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Jun 27, 2008 at 6:06 PM, Clark Williams
<clark.williams@xxxxxxxxx> wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> Steven Rostedt wrote:
>> 5B
>>
>> On Fri, 27 Jun 2008, Leon Woestenberg wrote:
>>
>>> Hello,
>>>
>>> I still found it strange that the RTWiki mentions "-t NUM" as if it
>>> works, so the manual page of cyclictest and the wiki needs a review
>>> too.
>>
>> It doesn't?
>>
>> Then again I must have an old version of cyclictest, because both -t5 and
>> -t 5 work for me.
>>
>> -- Steve
>>
>
> You do. The current source in Thomas's git tree exhibits this
> behavior, because of the way getopt() handles optional arguments.
>
> Clark

Right the extra-code is only necessary for the processing of optional
arguments, so without checking the history of the program, I would
assume that the NUM argument to -t was not optional in the past. Now
it is optional because -t without arguments implies threads =
max_cpus. I made some very minor edits to the wiki a little while ago
to reflect this but the Wiki page does need to updated more, I think
the usage file corresponds a lot more closely to the actual behaviour.

crap, I see I left of the signed-off-by: John Kacur <jkacur@xxxxxxxxx>
line on the patch, do I need to resubmit it?

John
--
To unsubscribe from this list: send the line "unsubscribe linux-rt-users" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [RT Stable]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Video 4 Linux]     [Device Mapper]

  Powered by Linux