Hi Stefan, On Fri, Dec 13, 2019 at 4:59 AM Stefan Schaeckeler <schaecsn@xxxxxxx> wrote: > > Hello Amit, > > > On Thu, Dec 12, 2019 at 11:47 AM Stefan Schaeckeler <schaecsn@xxxxxxx> wrote: > > > > > > By default, of-based thermal drivers do not enable hwmon. > > > Explicitly enable hwmon for both, the soc and gpu temperature > > > sensor. > > > > Is there any reason you need to expose this in hwmon? > > Why hwmon: > > The soc embedds temperature sensors and hwmon is the standard way to expose > sensors. Let me rephrase - is there something in the hwmon subsystem that is needed that isn't provided by the thermal subsystem inside /sys/class/thermal? > Sensors exposed by hwmon are automagically found by userland clients. Users > want to run sensors(1) and expect them to show up. > That is a good point. In which case, I wonder if we should just fix this in of-thermal.c instead of requiring individual drivers to do write boilerplate code. I'm thinking of a flag that the driver could set to enable the thermal_hwmon interface for of-thermal drivers. > Why in rockchip_thermal.c: > > drivers/thermal/ provides a high-level hwmon api in thermal_hwmon.[hc] which is > used by at least these thermal drivers: rcar_gen3_thermal.c, rcar_thermal.c, > st/stm_thermal.c, and broadcom/bcm2835_thermal.c. I want to hook up > rockchip_thermal.c exactly the same way. > > Apparently, other architectures hook up the cpu temperature sensors to hwmon > elsewhere. Most seem to do this in hwmon/, e.g. hwmon/coretemp.c. These drivers > are written from scratch. Utilizing thermal_hwmon.[ch] for chips which have > already drivers in drivers/thermal/ seems to be more elegant. > > Stefan _______________________________________________ Linux-rockchip mailing list Linux-rockchip@xxxxxxxxxxxxxxxxxxx http://lists.infradead.org/mailman/listinfo/linux-rockchip
