Hello Amit, > On Thu, Dec 12, 2019 at 11:47 AM Stefan Schaeckeler <schaecsn@xxxxxxx> wrote: > > > > By default, of-based thermal drivers do not enable hwmon. > > Explicitly enable hwmon for both, the soc and gpu temperature > > sensor. > > Is there any reason you need to expose this in hwmon? Why hwmon: The soc embedds temperature sensors and hwmon is the standard way to expose sensors. Sensors exposed by hwmon are automagically found by userland clients. Users want to run sensors(1) and expect them to show up. Why in rockchip_thermal.c: drivers/thermal/ provides a high-level hwmon api in thermal_hwmon.[hc] which is used by at least these thermal drivers: rcar_gen3_thermal.c, rcar_thermal.c, st/stm_thermal.c, and broadcom/bcm2835_thermal.c. I want to hook up rockchip_thermal.c exactly the same way. Apparently, other architectures hook up the cpu temperature sensors to hwmon elsewhere. Most seem to do this in hwmon/, e.g. hwmon/coretemp.c. These drivers are written from scratch. Utilizing thermal_hwmon.[ch] for chips which have already drivers in drivers/thermal/ seems to be more elegant. Stefan _______________________________________________ Linux-rockchip mailing list Linux-rockchip@xxxxxxxxxxxxxxxxxxx http://lists.infradead.org/mailman/listinfo/linux-rockchip
