On 09.04.2019 22:59, David Miller wrote: > From: Heiner Kallweit <hkallweit1@xxxxxxxxx> > Date: Sun, 7 Apr 2019 11:57:13 +0200 > >> Recently genphy_read_abilities() has been added that dynamically detects >> clause 22 PHY abilities. I *think* this detection should work with all >> supported PHY's, at least for the ones with basic features sets, i.e. >> PHY_BASIC_FEATURES and PHY_GBIT_FEATURES. So let's remove setting these >> features explicitly and rely on phylib feature detection. >> >> I don't have access to most of these PHY's, therefore I'd appreciate >> regression testing. >> >> Signed-off-by: Heiner Kallweit <hkallweit1@xxxxxxxxx> > > This appears to need to be done differently. > > A question was asked as to why fast ethernet PHY identification from the > source is important, well I'd say it's important for someone working on > the PHY code to see how "all fast ethernet PHY drivers do or handle X" > Then, what we could do: Change all occurrences of .features = PHY_XXX_FEATURES to /* PHY_XXX_FEATURES */ Would this be an acceptable option? > :-) > _______________________________________________ Linux-rockchip mailing list Linux-rockchip@xxxxxxxxxxxxxxxxxxx http://lists.infradead.org/mailman/listinfo/linux-rockchip
