On 3/8/2019 6:26 PM, Leonidas P. Papadakos wrote:
When I submitted the patch to fix the TX stability issue, I
intended to follow up with another patch for delay updates.
Unfortunately, I was unable to locate a delay that was acceptable,
as I was never able to get below ~700 retry attempts on the TX
side in testing.
I am unsure if this is due to manufacturing defects or if I'm
missing something else.
It may be worth considering implementing some sort of delay auto
tuning, similar to the mmc driver.
Thoughts?
I feared as much. The delays on the tx side do seem to be more of a
mitigation.
I you have the know-how for it, it would be pretty cool
Interesting approach to this by ayufan:
https://github.com/ayufan-rock64/linux-mainline-kernel/commit/41eeb7cd789ea7cac0cbf4b35b53055f354da757
I hope he sends it upstream as well
So I discovered the cause of my TX issues, at least on my rk3328-roc-cc.
The rk3328.dtsi is missing several rgmii tx pull strength values.
This is causing them to default to 0ma.
I've pushed them to 12ma, same as the other tx values, and I'm getting
600 mbps tx, with no TX failures.
I am also going to test his adaptive patch once it's done building.
Thoughts?
diff --git a/arch/arm65/boot/dts/rockchip/rk3328-roc-cc.dts
b/arch/arm64/boot/dts/rockchip/rk3328-roc-cc.dts
index c0519bc5884e..696627bf3331 100644
--- a/arch/arm64/boot/dts/rockchip/rk3328-roc-cc.dts
+++ b/arch/arm64/boot/dts/rockchip/rk3328-roc-cc.dts
@@ -280,6 +280,26 @@
rockchip,pins = <0 RK_PA0 RK_FUNC_GPIO &pcfg_pull_none>;
};
};
+
+ gmac-1 {
+ rgmiim1_pins: rgmiim1-pins {
+ rockchip,pins =
+ /* mac_txclk */
+ <0 RK_PB0 1 &pcfg_pull_none_12ma>,
+ /* mac_txen */
+ <0 RK_PB4 1 &pcfg_pull_none_12ma>,
+ /* mac_clk */
+ <0 RK_PD0 1 &pcfg_pull_none_12ma>,
+ /* mac_txd1 */
+ <0 RK_PC0 1 &pcfg_pull_none_12ma>,
+ /* mac_txd0 */
+ <0 RK_PC1 1 &pcfg_pull_none_12ma>,
+ /* mac_txd3 */
+ <0 RK_PC7 1 &pcfg_pull_none_12ma>,
+ /* mac_txd2 */
+ <0 RK_PC6 1 &pcfg_pull_none_12ma>;
+ };
+ };
};
&sdmmc {
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@xxxxxxxxxxxxxxxxxxx
http://lists.infradead.org/mailman/listinfo/linux-rockchip
