Re: [PATCH] arm64: dts: Remove inconsistent use of 'arm,armv8' compatible string

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 14:29-20190109, Rob Herring wrote:
> The 'arm,armv8' compatible string is only for software models. It adds
> little value otherwise and is inconsistently used as a fallback on some
> platforms. Remove it from those platforms.
> 
> This fixes warnings generated by the DT schema.
> 
> Reported-by: Michal Simek <michal.simek@xxxxxxxxxx>
> Cc: Mark Rutland <mark.rutland@xxxxxxx>
> Cc: Will Deacon <will.deacon@xxxxxxx>
> Signed-off-by: Rob Herring <robh@xxxxxxxxxx>
> ---
[...]

ARM SoC maintainers, At least on a quick look (I could be wrong), I
think we don't have any explicit processor bindings documentation.

However, most of SoC folks seem to key off matches else where I
guess..

Not sure, while at this, you if you are planning on fixing up
Documentation/devicetree/bindings/arm/arm-boards:
compatible = "arm,cortex-a53","arm,armv8";
Documentation/devicetree/bindings/arm/cpu-capacity.txt:
compatible = "arm,cortex-a53","arm,armv8";

Anyways, for TI SoC:

>  arch/arm64/boot/dts/ti/k3-am654.dtsi          |   8 +-
> diff --git a/arch/arm64/boot/dts/ti/k3-am654.dtsi b/arch/arm64/boot/dts/ti/k3-am654.dtsi
> index 2affa6f6617e..b221abf43ac2 100644
> --- a/arch/arm64/boot/dts/ti/k3-am654.dtsi
> +++ b/arch/arm64/boot/dts/ti/k3-am654.dtsi
> @@ -34,7 +34,7 @@
>  		};
>  
>  		cpu0: cpu@0 {
> -			compatible = "arm,cortex-a53", "arm,armv8";
> +			compatible = "arm,cortex-a53";
>  			reg = <0x000>;
>  			device_type = "cpu";
>  			enable-method = "psci";
> @@ -48,7 +48,7 @@
>  		};
>  
>  		cpu1: cpu@1 {
> -			compatible = "arm,cortex-a53", "arm,armv8";
> +			compatible = "arm,cortex-a53";
>  			reg = <0x001>;
>  			device_type = "cpu";
>  			enable-method = "psci";
> @@ -62,7 +62,7 @@
>  		};
>  
>  		cpu2: cpu@100 {
> -			compatible = "arm,cortex-a53", "arm,armv8";
> +			compatible = "arm,cortex-a53";
>  			reg = <0x100>;
>  			device_type = "cpu";
>  			enable-method = "psci";
> @@ -76,7 +76,7 @@
>  		};
>  
>  		cpu3: cpu@101 {
> -			compatible = "arm,cortex-a53", "arm,armv8";
> +			compatible = "arm,cortex-a53";
>  			reg = <0x101>;
>  			device_type = "cpu";
>  			enable-method = "psci";

Acked-by: Nishanth Menon <nm@xxxxxx>

-- 
Regards,
Nishanth Menon

_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@xxxxxxxxxxxxxxxxxxx
http://lists.infradead.org/mailman/listinfo/linux-rockchip



[Index of Archives]     [LM Sensors]     [Linux Sound]     [ALSA Users]     [ALSA Devel]     [Linux Audio Users]     [Linux Media]     [Kernel]     [Gimp]     [Yosemite News]     [Linux Media]

  Powered by Linux