On Sun, Nov 25, 2018 at 1:19 PM Otavio Salvador <otavio@xxxxxxxxxxxxxxxx> wrote: > > From: Fabio Berton <fabio.berton@xxxxxxxxxxxxxxxx> > > Signed-off-by: Fabio Berton <fabio.berton@xxxxxxxxxxxxxxxx> > Signed-off-by: Otavio Salvador <otavio@xxxxxxxxxxxxxxxx> Hi Otavio, Thanks for these patches. I don't have a reason to _not_ enable systemd features, but would you mind providing a brief description of what's not working without this change? Is it completely broken, or is it just the random-UID featues that don't work, or something else?. Useful for others to know what's expected to break if someone turns them off, etc. Also, I noticed you posted a series of 13 patches, which includes some dts files for rv1108, some network driver changes and some of these more generic defconfig changes. I would suggest that you split up your patches into independent series where possible, especially when they end up going to different subsystems. Providing suitable cover letters for the series when you post them is also useful to help reviewers by summarizing the series, including changes from last time it was posted, etc. Please address it to the superset of patch receivers on the series. I'm asking for the cover letter because this time I was wondering if there was a reason for the mix of patches so I went looking for it. Maybe there is a need to group them together even though the sub-series seem somewhat independent -- I can't tell from the way they were posted. Thanks! -Olof _______________________________________________ Linux-rockchip mailing list Linux-rockchip@xxxxxxxxxxxxxxxxxxx http://lists.infradead.org/mailman/listinfo/linux-rockchip
