Hi, On Tue, Nov 13, 2018 at 4:35 PM Katsuhiro Suzuki <katsuhiro@xxxxxxxxxxxxx> wrote: > > Hello, > > Sorry to distrub you. I can't reproduce the problem on my device, so > I want to confirm the current situation. > > Q1. > Which device-tree are you using? > > This one? > > https://chromium.googlesource.com/chromiumos/third_party/kernel/+/stabilize-7202.B-chromeos-3.14/arch/arm/boot/dts/rk3288-speedy.dts > > It seems i2s node does not have dma properties. I guess this is the > reason of Oops. No, the one that comes with the mainline kernel slightly modified for things like HDMI, but have not touched the sound parts: https://github.com/torvalds/linux/blob/v4.19/arch/arm/boot/dts/rk3288-veyron-speedy.dts for the sound: https://github.com/torvalds/linux/blob/v4.19/arch/arm/boot/dts/rk3288-veyron-analog-audio.dtsi Just for reference if you need to know the kernel config or something, i follow archlinux-arm's linux-armv7 with my own patches added on top of them at: https://github.com/urjaman/arch-c201/tree/master/linux-c201 The commit that it is at currently ("update to linux-4.19.0") is the one that has EINVAL. I'll push one with a patch doing the (3) below soon-ish. > Q2. > Which combination is working on your device? My understanding as > following: > > 4.19 : Working > 4.19 + (1) : Unknown > 4.19 + (2) : EINVAL > 4.19 + (1) + (2) : Oops and crush > 4.19 + (3) : Working?? > > (1): 75b31192fe6ad20b42276b20ee3bdf1493216d63 > "ASoC: rockchip: add config for rockchip dmaengine pcm register" > (2): 24d6638302b48328a58c13439276d4531af4ca7d > "ASoC: rockchip: add missing INTERLEAVED PCM attribute" > (3): Change arguments of devm_snd_dmaengine_pcm_register > to (dev, NULL, 0) 4.19 + (1) is 4.19, that is (1) is included in 4.19.0. So: 4.19 : EINVAL 4.19 + (2): Oops and eventually hang or crash 4.19 + (3): Working (this tree included (2) but that is irrelevant since that info isnt used...) My last tested working before 4.19.0 was 4.18.8 (i update kinda rarely it seems), this doesnt include (1) and was working. Thanks, Urja Rannikko _______________________________________________ Linux-rockchip mailing list Linux-rockchip@xxxxxxxxxxxxxxxxxxx http://lists.infradead.org/mailman/listinfo/linux-rockchip
