Hello,
Sorry to distrub you. I can't reproduce the problem on my device, so
I want to confirm the current situation.
Q1.
Which device-tree are you using?
This one?
https://chromium.googlesource.com/chromiumos/third_party/kernel/+/stabilize-7202.B-chromeos-3.14/arch/arm/boot/dts/rk3288-speedy.dts
It seems i2s node does not have dma properties. I guess this is the
reason of Oops.
Q2.
Which combination is working on your device? My understanding as
following:
4.19 : Working
4.19 + (1) : Unknown
4.19 + (2) : EINVAL
4.19 + (1) + (2) : Oops and crush
4.19 + (3) : Working??
(1): 75b31192fe6ad20b42276b20ee3bdf1493216d63
"ASoC: rockchip: add config for rockchip dmaengine pcm register"
(2): 24d6638302b48328a58c13439276d4531af4ca7d
"ASoC: rockchip: add missing INTERLEAVED PCM attribute"
(3): Change arguments of devm_snd_dmaengine_pcm_register
to (dev, NULL, 0)
Best Regards,
---
Katsuhiro Suzuki
On 2018年11月11日 03:23, Urja Rannikko wrote:
Hi,
On Sat, Nov 10, 2018 at 5:07 PM Katsuhiro Suzuki
<katsuhiro@xxxxxxxxxxxxx> wrote:
Hello,
Thank you for your comment and sorry for breaking your environment.
To be honest, afaik you didnt really break it, more just showed how
broken it already was.
Would you try to change the arguments as following
devm_snd_dmaengine_pcm_register(dev, NULL, 0);
in rockchip_pcm.c?
That is actually what i did to "revert" it since my kernel build tree
isnt a git tree and doing that was faster,
so I already did that.
Is it work on your environment or not? If it works, I think it's
better to remove whole snd_pcm_hardware and snd_dmaengine_pcm_config
settings from rockchip_pcm.c instead of my previous and current patches.
Yes it works, whether that is the best course of action is up to you all.
Thanks,
Urja Rannikko
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@xxxxxxxxxxxxxxxxxxx
http://lists.infradead.org/mailman/listinfo/linux-rockchip
